Alexandre, I would suggest that you give me comments on this patch. The upload procedure at your end takes a bit of time and therefore that might be the fastest way to land this.
Once this has landed you can upload your vabs implementation, test and enable the vabs in this code. Does that sound reasonable? Cheers, -- Mads On Wed, Jan 19, 2011 at 4:50 PM, Alexandre Rames <[email protected]>wrote: > Hi, > > I implemented this also and we were going to push it... My patch includes > the vabs support (including disasm and simulator), as well as a cctest for > vabs. > > Do you want me to upload it? (I can do it now). Otherwise I have a few > comments / suggestions on this patch. > > Regards > > Alexandre > > > On Wed, Jan 19, 2011 at 3:31 PM, <[email protected]> wrote: > >> Reviewers: Søren Gjesse, >> >> Description: >> ARM: Implement Math.abs in lithium code generator for the integer and >> tagged case. I couldn't find a way to test the double case yet so I'm >> leaving that unimplemented for now. >> >> Please review this at http://codereview.chromium.org/6347007/ >> >> SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge >> >> Affected files: >> M src/arm/assembler-arm.h >> M src/arm/frames-arm.h >> M src/arm/lithium-codegen-arm.h >> M src/arm/lithium-codegen-arm.cc >> M src/ia32/lithium-codegen-ia32.h >> M src/ia32/lithium-codegen-ia32.cc >> >> >> -- >> v8-dev mailing list >> [email protected] >> http://groups.google.com/group/v8-dev > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
