http://codereview.chromium.org/6308012/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right):
http://codereview.chromium.org/6308012/diff/1/src/arm/lithium-codegen-arm.cc#newcode1747 src/arm/lithium-codegen-arm.cc:1747: return gt; Shouldn't it return le (lower or equal)? http://codereview.chromium.org/6308012/diff/1/src/arm/lithium-codegen-arm.cc#newcode1765 src/arm/lithium-codegen-arm.cc:1765: __ LoadRoot(result, Heap::kTrueValueRootIndex, true_cond); The condition is unnecessary, you only jump here if it is true. Alternatively you can write: LoadRoot(result, Heap::kFalseValueRootIndex, NegateCondition(true_cond)); LoadRoot(result, Heap::kFalseValueRootIndex, true_cond); Then you don't need the branches. http://codereview.chromium.org/6308012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
