http://codereview.chromium.org/6308012/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right):
http://codereview.chromium.org/6308012/diff/1/src/arm/lithium-codegen-arm.cc#newcode1747 src/arm/lithium-codegen-arm.cc:1747: return gt; On 2011/01/21 09:26:21, Rodolph Perfetta wrote:
Shouldn't it return le (lower or equal)?
Done. http://codereview.chromium.org/6308012/diff/1/src/arm/lithium-codegen-arm.cc#newcode1765 src/arm/lithium-codegen-arm.cc:1765: __ LoadRoot(result, Heap::kTrueValueRootIndex, true_cond); I removed the condition. It was a leftover from writing the code in the form you propose. The problem is that EmitIsObject may directly jump to the labels provided, so I decided to keep the labels. On 2011/01/21 09:26:21, Rodolph Perfetta wrote:
The condition is unnecessary, you only jump here if it is true.
Alternatively you can write: LoadRoot(result, Heap::kFalseValueRootIndex,
NegateCondition(true_cond));
LoadRoot(result, Heap::kFalseValueRootIndex, true_cond); Then you don't need the branches.
http://codereview.chromium.org/6308012/diff/1/src/arm/lithium-codegen-arm.cc#newcode1781 src/arm/lithium-codegen-arm.cc:1781: Condition true_cond = EmitIsObject(reg, temp1, temp2, false_label, true_label); On 2011/01/21 07:38:13, Søren Gjesse wrote:
Long line.
Done. http://codereview.chromium.org/6308012/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
