LGTM if non-strict code in either Safari or Firefox already throw exceptions where we will now do it.
http://codereview.chromium.org/6335010/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/6335010/diff/1/src/parser.cc#newcode3037 src/parser.cc:3037: GetAccessor = 0x01, Add a "k" in front of constants, i.e., kGetAccessor, kSetAccessor, kAccessor, kData. http://codereview.chromium.org/6335010/diff/1/src/parser.cc#newcode3043 src/parser.cc:3043: HashMap props; Properties should be at the end of the class, after methods (including static methods). http://codereview.chromium.org/6335010/diff/1/src/parser.cc#newcode3050 src/parser.cc:3050: default: Move the default to the end instead. I just think it reads better :) http://codereview.chromium.org/6335010/diff/1/src/parser.cc#newcode3077 src/parser.cc:3077: ASSERT(!name->AsArrayIndex(&hash)); I'm a little worried that we might have a symbol that is also a valid ArrayIndex. We might not, but I haven't been able to convince myself that it can't happen yet. http://codereview.chromium.org/6335010/diff/1/src/parser.cc#newcode3108 src/parser.cc:3108: // Data property conflicting with an accessor. We should be careful when adding restrictions to non-strict code that isn't there already. There is a potential to break existing code on the web. We should at least check whether other significant browsers already fail on the code, and not be the first to break the code. http://codereview.chromium.org/6335010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
