True. The changes are only in cases that didn't exist in ES3, so it's not a
backwards compatibility problem.
Ok, I agree to keep the non-strict-mode restrictions, but change
the "symbols
are not array indices" assumption, e.g., by checking for array indices
first.
http://codereview.chromium.org/6335010/diff/1/src/parser.cc
File src/parser.cc (right):
http://codereview.chromium.org/6335010/diff/1/src/parser.cc#newcode3077
src/parser.cc:3077: ASSERT(!name->AsArrayIndex(&hash));
Damnit. I fixed one such place already, but it seems there are more.
It's good that you found it :)
It's NOT safe. The ASSERT gets hit by, e.g.:
var y = {get "1234"() {return 42; }};
http://codereview.chromium.org/6335010/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
