LGTM
http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.cc#newcode901 src/arm/lithium-arm.cc:901: // TODO(fschneider): Handle test instructions uniformly like Username -> issue number http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h File src/arm/lithium-arm.h (right): http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h#newcode336 src/arm/lithium-arm.h:336: template<typename T, int N> I know that templates are usually specified using single uppercase letters, but it is sometimes quite difficult to guess what they specify (here T is a type in one place and the temporary count in another place). A short comment on what each argument specify would be nice. And maybe use names - a least for the non-type arguments. http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h#newcode531 src/arm/lithium-arm.h:531: Any particular reason for not keeping the LBinaryOperation? template<int T> class LBinaryOperation: public LTemplateInstruction<1, 2, T> { ... http://codereview.chromium.org/6250027/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
