http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.cc#newcode901
src/arm/lithium-arm.cc:901: // TODO(fschneider): Handle test
instructions uniformly like
On 2011/01/24 08:08:40, Søren Gjesse wrote:
Username -> issue number
I removed the todo since it really is part of our bigger refactoring of
the IR.
http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):
http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h#newcode336
src/arm/lithium-arm.h:336: template<typename T, int N>
On 2011/01/24 08:08:40, Søren Gjesse wrote:
I know that templates are usually specified using single uppercase
letters, but
it is sometimes quite difficult to guess what they specify (here T is
a type in
one place and the temporary count in another place). A short comment
on what
each argument specify would be nice. And maybe use names - a least for
the
non-type arguments.
Done.
http://codereview.chromium.org/6250027/diff/7001/src/arm/lithium-arm.h#newcode531
src/arm/lithium-arm.h:531:
On 2011/01/24 08:08:40, Søren Gjesse wrote:
Any particular reason for not keeping the LBinaryOperation?
template<int T>
class LBinaryOperation: public LTemplateInstruction<1, 2, T> {
...
I preferred always having all three template parameters explicitly.
LBinaryOperation would be really just a typedef abbreviation for
LTemplateInstruction<1, 2, T>.
http://codereview.chromium.org/6250027/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
