LGTM, with one suggestion.
http://codereview.chromium.org/6323002/diff/40001/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/6323002/diff/40001/src/ic.cc#newcode1202 src/ic.cc:1202: stub = pixel_array_stub(); True, we don't deal with it in that case and I guess it will not harm much to leave it in the generic stub. However, can we share some of the code generation code in that case? Create a static helper method GenerateLoadFromPixelArray that generates the code for everything but the receiver check? On 2011/01/25 20:56:29, danno wrote:
This occurred to me too, but I actually think we still need it...
Otherwise how
do we handle pixel arrays in the case of a call site that goes
megamorphic?
On 2011/01/25 14:49:17, Mads Ager wrote: > Let's remove the pixel array code in the generic stub now that we
have a
special > IC stub?
http://codereview.chromium.org/6323002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
