addressed feedback, added test cases to exercise IC code paths.
http://codereview.chromium.org/6323002/diff/28003/src/arm/ic-arm.cc File src/arm/ic-arm.cc (right): http://codereview.chromium.org/6323002/diff/28003/src/arm/ic-arm.cc#newcode1408 src/arm/ic-arm.cc:1408: __ BranchOnNotSmi(key, &slow); On 2011/01/26 21:35:17, Søren Gjesse wrote:
This has changed to JumpIfNotSmi.
Done. http://codereview.chromium.org/6323002/diff/28003/src/arm/ic-arm.cc#newcode1410 src/arm/ic-arm.cc:1410: __ mov(index, Operand(key, ASR, kSmiTagSize)); // Untag index On 2011/01/26 21:35:17, Søren Gjesse wrote:
There is a SmiUntag instruction in the macro assembler which takes two registres.
Done. http://codereview.chromium.org/6323002/diff/28003/src/arm/ic-arm.cc#newcode1418 src/arm/ic-arm.cc:1418: __ mov(r0, Operand(scratch2, LSL, kSmiTagSize)); // Tag result as smi. On 2011/01/26 21:35:17, Søren Gjesse wrote:
There is also a SmiTag which takes two registers, but you could just
load it
into r0 and use SmiTag on one register.
Done. http://codereview.chromium.org/6323002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
