LGTM.
But, if we don't think it is performance critical to have the fast path, we
could also fix it by narrowing the application of the special case that
follows
(I think...).
http://codereview.chromium.org/6357025/diff/2001/src/array.js
File src/array.js (right):
http://codereview.chromium.org/6357025/diff/2001/src/array.js#newcode612
src/array.js:612: if (num_arguments > 1) {
This is pretty weird. It looks like the special case is only for not
delete count if start is given, i.e.:
if (num_arguments != 1) {
// The normal thing according to the algorithm.
} else {
del_count = len - start_i;
}
http://codereview.chromium.org/6357025/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
