Ok, Kevin, may you have a look, esp. at the changed wording, please? yours, anton.
On Mon, Jan 31, 2011 at 3:32 PM, <[email protected]> wrote: > Looks good. I agree that we should keep the two implementations as close as > reasonable. > > Maybe the comment about compatibility should actually say what behavior > we're > trying to achieve (though spelling it out makes it seem like a silly > behavior: > "An undefined 'deleteCount' argument deletes no elements, however an absent > 'deleteCount' argument deletes all elements starting from the 'start' > argument, > unless the 'start' argument is also absent.") > > > http://codereview.chromium.org/6357025/diff/6002/src/array.js > File src/array.js (right): > > http://codereview.chromium.org/6357025/diff/6002/src/array.js#newcode610 > src/array.js:610: if (num_arguments != 1) { > OK. Now maybe it's clearer to change the comparison to (num_arguments > == 1) and flip the branches? (Also in the C++ code.) > > http://codereview.chromium.org/6357025/ > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
