LGTM with nit.
Thanks a lot for fixing this. We should probably merge this to the 3.0
branch,
especially because of the fix for 1092 (I can do this after it has landed)
http://codereview.chromium.org/6286060/diff/1/.gitignore
File .gitignore (right):
http://codereview.chromium.org/6286060/diff/1/.gitignore#newcode29
.gitignore:29: test/sputnik/sputniktests
I don't use git, but since this is a directory should it not be:
/test/sputnik/sputniktests
like the other directories?
In addition, I think we should move it up right after /obj/ - the other
directories seems to be in alphabetic order.
http://codereview.chromium.org/6286060/diff/1/test/mjsunit/regress/regress-1092.js
File test/mjsunit/regress/regress-1092.js (right):
http://codereview.chromium.org/6286060/diff/1/test/mjsunit/regress/regress-1092.js#newcode30
test/mjsunit/regress/regress-1092.js:30: // JSGlobalProxy
Period at end of comment.
http://codereview.chromium.org/6286060/diff/1/test/mjsunit/regress/regress-1092.js#newcode32
test/mjsunit/regress/regress-1092.js:32:
Could we put each statement on individual lines?
http://codereview.chromium.org/6286060/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
