http://codereview.chromium.org/6286060/diff/1/.gitignore File .gitignore (right):
http://codereview.chromium.org/6286060/diff/1/.gitignore#newcode29 .gitignore:29: test/sputnik/sputniktests On 2011/02/03 06:49:47, Rico wrote:
I don't use git, but since this is a directory should it not be: /test/sputnik/sputniktests like the other directories? In addition, I think we should move it up right after /obj/ - the
other
directories seems to be in alphabetic order.
Done. http://codereview.chromium.org/6286060/diff/1/test/mjsunit/regress/regress-1092.js File test/mjsunit/regress/regress-1092.js (right): http://codereview.chromium.org/6286060/diff/1/test/mjsunit/regress/regress-1092.js#newcode30 test/mjsunit/regress/regress-1092.js:30: // JSGlobalProxy On 2011/02/03 06:49:47, Rico wrote:
Period at end of comment.
Done. http://codereview.chromium.org/6286060/diff/1/test/mjsunit/regress/regress-1092.js#newcode32 test/mjsunit/regress/regress-1092.js:32: On 2011/02/03 06:49:47, Rico wrote:
Could we put each statement on individual lines?
Done. http://codereview.chromium.org/6286060/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
