LGTM and to Erik as well. I'll land addressing myself minor formatting issues.

Thanks for a great work, Zaheer.


http://codereview.chromium.org/6170001/diff/129005/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6170001/diff/129005/src/arm/code-stubs-arm.cc#newcode5735
src/arm/code-stubs-arm.cc:5735: RelocInfo::CODE_TARGET));
indentation is slightly off.

http://codereview.chromium.org/6170001/diff/129005/src/assembler.cc
File src/assembler.cc (right):

http://codereview.chromium.org/6170001/diff/129005/src/assembler.cc#newcode902
src/assembler.cc:902: ExternalReference::
I'll format it differently.

http://codereview.chromium.org/6170001/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to