http://codereview.chromium.org/6170001/diff/125002/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/6170001/diff/125002/src/arm/macro-assembler-arm.cc#newcode670 src/arm/macro-assembler-arm.cc:670: // Reserve place for the return address and align the frame preparing for Please update this comment. http://codereview.chromium.org/6170001/diff/125002/src/arm/macro-assembler-arm.cc#newcode1482 src/arm/macro-assembler-arm.cc:1482: ASSERT(allow_stub_calls()); // stub calls are not allowed in some stubs Start comment with uppercase letter end and with period. http://codereview.chromium.org/6170001/diff/125002/src/arm/macro-assembler-arm.cc#newcode1520 src/arm/macro-assembler-arm.cc:1520: // return address pushed on stack (could have moved after GC). As far as I can see this relies on DirectCEntryStub itself never moving. It is the same assumption we have for the CEntryStub (and the RegExpCEntryStub I think). Please add a comment on this. For the CEntryStub we have been safe so far as it is generated quite early (with crankshaft this is actually not the case for the variant that saves doubles). How about this will it be generated early, or can a test case where this actually moves be crafted? http://codereview.chromium.org/6170001/diff/125002/src/arm/macro-assembler-arm.cc#newcode1521 src/arm/macro-assembler-arm.cc:1521: DirectCEntryStub stub; I thing the calling of this stub should be factored out, maybe to a method on the stub stub.GenerateCall(ref) as this relies on the exact code generated by the stub. http://codereview.chromium.org/6170001/diff/125002/src/assembler.h File src/assembler.h (right): http://codereview.chromium.org/6170001/diff/125002/src/assembler.h#newcode471 src/assembler.h:471: // BUILTIN_CALL - builtin/runtime call. builtin/runtime -> builtin http://codereview.chromium.org/6170001/diff/125002/src/assembler.h#newcode474 src/assembler.h:474: // FP_CALL - builtin/runtime call that returns floating point. Please change "builtin/runtime call that returns floating point." to something like "direct call to a C-function which will never cause a GC". It is not always a function with the signature double f(double, double), e.g. "native_compare_doubles". http://codereview.chromium.org/6170001/diff/125002/src/assembler.h#newcode483 src/assembler.h:483: FP_RETURN_CALL, FP_RETURN_CALL -> FP_CALL as in comment. http://codereview.chromium.org/6170001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
