http://codereview.chromium.org/6286078/diff/1/AUTHORS File AUTHORS (right):
http://codereview.chromium.org/6286078/diff/1/AUTHORS#newcode38 AUTHORS:38: Mike Gilbert <[email protected]> Perhaps you could move Mike who is not in alphabetical order here. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5743 src/arm/code-stubs-arm.cc:5743: Missing blank line. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5747 src/arm/code-stubs-arm.cc:5747: and here http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5755 src/arm/code-stubs-arm.cc:5755: __ mov(r2, Operand(reinterpret_cast<intptr_t>(ref.address()))); There is a constructor for Operand that takes an external reference. I think you have to use that otherwise this doesn't work correctly with snapshots. The snapshot code needs the reloc information from a real Operand in case the destination is different in mksnapshot and the final executable. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5756 src/arm/code-stubs-arm.cc:5756: __ add(ip, pc, Operand(4)); It seems to me that omitting this add and just using ip in the next instruction would achieve the same. Pc is always 8 bytes ahead of the actual instruction executing so that should be the same. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5760 src/arm/code-stubs-arm.cc:5760: and missing blank line here http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.h File src/arm/code-stubs-arm.h (right): http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.h#newcode572 src/arm/code-stubs-arm.h:572: Missing blank line. http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc#newcode1830 src/arm/macro-assembler-arm.cc:1830: Blank line http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc#newcode1840 src/arm/macro-assembler-arm.cc:1840: Blank line http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc#newcode1857 src/arm/macro-assembler-arm.cc:1857: Blank line http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc#newcode1868 src/arm/macro-assembler-arm.cc:1868: Blank line http://codereview.chromium.org/6286078/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/6286078/diff/1/src/heap.cc#newcode1944 src/heap.cc:1944: Blank lines. http://codereview.chromium.org/6286078/diff/1/src/heap.cc#newcode1951 src/heap.cc:1951: Blank lines. http://codereview.chromium.org/6286078/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
