All comments except for one are addressed,
http://codereview.chromium.org/6286078/diff/1/AUTHORS File AUTHORS (right): http://codereview.chromium.org/6286078/diff/1/AUTHORS#newcode38 AUTHORS:38: Mike Gilbert <[email protected]> On 2011/02/04 09:55:55, Erik Corry wrote:
Perhaps you could move Mike who is not in alphabetical order here.
Done. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5743 src/arm/code-stubs-arm.cc:5743: On 2011/02/04 09:55:55, Erik Corry wrote:
Missing blank line.
Done. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5747 src/arm/code-stubs-arm.cc:5747: On 2011/02/04 09:55:55, Erik Corry wrote:
and here
Done. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5755 src/arm/code-stubs-arm.cc:5755: __ mov(r2, Operand(reinterpret_cast<intptr_t>(ref.address()))); On 2011/02/04 09:55:55, Erik Corry wrote:
There is a constructor for Operand that takes an external reference.
I think
you have to use that otherwise this doesn't work correctly with
snapshots. The
snapshot code needs the reloc information from a real Operand in case
the
destination is different in mksnapshot and the final executable.
Done. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5756 src/arm/code-stubs-arm.cc:5756: __ add(ip, pc, Operand(4)); On 2011/02/04 09:55:55, Erik Corry wrote:
It seems to me that omitting this add and just using ip in the next
instruction
would achieve the same. Pc is always 8 bytes ahead of the actual
instruction
executing so that should be the same.
Hmm, ip would have any garbage then. Am I missing something. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.cc#newcode5760 src/arm/code-stubs-arm.cc:5760: On 2011/02/04 09:55:55, Erik Corry wrote:
and missing blank line here
Done. http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.h File src/arm/code-stubs-arm.h (right): http://codereview.chromium.org/6286078/diff/1/src/arm/code-stubs-arm.h#newcode572 src/arm/code-stubs-arm.h:572: On 2011/02/04 09:55:55, Erik Corry wrote:
Missing blank line.
Done. http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc#newcode1830 src/arm/macro-assembler-arm.cc:1830: On 2011/02/04 09:55:55, Erik Corry wrote:
Blank line
Done. http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc#newcode1840 src/arm/macro-assembler-arm.cc:1840: On 2011/02/04 09:55:55, Erik Corry wrote:
Blank line
Done. http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc#newcode1857 src/arm/macro-assembler-arm.cc:1857: On 2011/02/04 09:55:55, Erik Corry wrote:
Blank line
Done. http://codereview.chromium.org/6286078/diff/1/src/arm/macro-assembler-arm.cc#newcode1868 src/arm/macro-assembler-arm.cc:1868: On 2011/02/04 09:55:55, Erik Corry wrote:
Blank line
Done. http://codereview.chromium.org/6286078/diff/1/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/6286078/diff/1/src/heap.cc#newcode1944 src/heap.cc:1944: On 2011/02/04 09:55:55, Erik Corry wrote:
Blank lines.
Done. http://codereview.chromium.org/6286078/diff/1/src/heap.cc#newcode1951 src/heap.cc:1951: On 2011/02/04 09:55:55, Erik Corry wrote:
Blank lines.
Done. http://codereview.chromium.org/6286078/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
