LGTM, but I'd be really glad to see pure v8 test for this stuff to catch regressions sooner.
http://codereview.chromium.org/6246103/diff/3006/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/6246103/diff/3006/src/v8natives.js#newcode497 src/v8natives.js:497: function ConvertDescriptorArrayToDescriptor(desc_array) { maybe you want to add something like assert(desc_array !== false) (in the form if (desc_array === false) throw 'Internal error: invalid desc_array) http://codereview.chromium.org/6246103/diff/3006/src/v8natives.js#newcode539 src/v8natives.js:539: // If p is not a property on obj undefined is returned. you might want to clarify what returned false means http://codereview.chromium.org/6246103/diff/3006/src/v8natives.js#newcode551 src/v8natives.js:551: if (current_or_access == false) return void 0; ===? http://codereview.chromium.org/6246103/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
