Addressed comments, I will make another change with a regression test to get this in and make the tree green.
http://codereview.chromium.org/6246103/diff/3006/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/6246103/diff/3006/src/v8natives.js#newcode497 src/v8natives.js:497: function ConvertDescriptorArrayToDescriptor(desc_array) { On 2011/02/04 11:41:33, antonm wrote:
maybe you want to add something like assert(desc_array !== false) (in
the form
if (desc_array === false) throw 'Internal error: invalid desc_array)
Done. http://codereview.chromium.org/6246103/diff/3006/src/v8natives.js#newcode539 src/v8natives.js:539: // If p is not a property on obj undefined is returned. On 2011/02/04 11:41:33, antonm wrote:
you might want to clarify what returned false means
Done. http://codereview.chromium.org/6246103/diff/3006/src/v8natives.js#newcode551 src/v8natives.js:551: if (current_or_access == false) return void 0; On 2011/02/04 11:41:33, antonm wrote:
===?
No, this will not return true on the return value (because we return the wrapper boolean) http://codereview.chromium.org/6246103/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
