http://codereview.chromium.org/6334106/diff/1/src/scanner.cc
File src/scanner.cc (right):
http://codereview.chromium.org/6334106/diff/1/src/scanner.cc#newcode519
src/scanner.cc:519: bool sign = (c0_ == '-');
On 2011/02/04 13:53:36, Lasse Reichstein wrote:
Call the variable "negative".
It's not obvious what "sign" being true means.
Done.
http://codereview.chromium.org/6334106/diff/1/src/scanner.cc#newcode521
src/scanner.cc:521: if (sign) AddLiteralCharAdvance();
On 2011/02/04 13:53:36, Lasse Reichstein wrote:
I would prefer:
bool negative = false;
if (c0_ == '-') {
negative = true;
AddLiteralCharAdvance();
}
Done.
http://codereview.chromium.org/6334106/diff/1/src/scanner.h
File src/scanner.h (right):
http://codereview.chromium.org/6334106/diff/1/src/scanner.h#newcode151
src/scanner.h:151: double number;
On 2011/02/04 13:53:36, Lasse Reichstein wrote:
Make it a private (or protected) property and call it number_, then
make a
function called number() that returns it.
This way, the number field is publicly writable.
Done.
http://codereview.chromium.org/6334106/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
