http://codereview.chromium.org/6334106/diff/8/src/scanner.h
File src/scanner.h (right):

http://codereview.chromium.org/6334106/diff/8/src/scanner.h#newcode152
src/scanner.h:152: double number() {
We generally don't use const in the V8 code.
It should work, and probably wouldn't hurt if added, but it's only
necessary if you ever have a const reference to the scanner, and we
probably won't have that either.

As for making it a one-liner ... I wouldn't insist either way either. I
prefer the three-line code, but I can understand the argument for having
more meaningful lines on screen at a atime.

http://codereview.chromium.org/6334106/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to