Drive by,
A large fraction of your comments are more than 80 characters wide.
Cheers,
Rico
On 2011/02/04 22:13:13, Martin Maly wrote:
Hi Mads, Lasse,
should have anticipated this one... The strict mode part of the es5conform
suite
was hiding behind a gate:
function isStrictSupported() {
"use strict";
try {
eval("with({}){};")
return false;
} catch (e) {
return e instanceof SyntaxError;
}
}
which I enabled with the eval commit. All of a sudden the strict mode
tests
actually run. Some fail because the strict mode implementation is not
complete,
others fail because thee tests themselves are not correct in places.
I adjusted the expectations file and put comments in there to note why
each
test
fails.
Thank you!
Martin
http://codereview.chromium.org/6396008/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
