LGTM
http://codereview.chromium.org/6396008/diff/1/test/es5conform/es5conform.status File test/es5conform/es5conform.status (right): http://codereview.chromium.org/6396008/diff/1/test/es5conform/es5conform.status#newcode399 test/es5conform/es5conform.status:399: # test uses implicit return (which doesn't seem to work in v8 or safari jsc) I think it's because the test was originally written for a harness where returning undefined was considered a success - and the author just forgot to return the result of the "instanceof" test. Still a bad test. (I'm not aware of any JS implementation with "implicit return", so just say that it fails to return a true value). http://codereview.chromium.org/6396008/diff/1/test/es5conform/es5conform.status#newcode434 test/es5conform/es5conform.status:434: # Invalid test case per ECMA-262 5th Edition, 10.1.1, bullet 4 The test seems correct to me. The Function call creates a function that is not strict, so it should be allowed to have two "a" parameters. I.e., the result of the test should be to not throw. How do we fail it? http://codereview.chromium.org/6396008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
