LGTM
http://codereview.chromium.org/6368138/diff/1002/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6368138/diff/1002/src/arm/lithium-codegen-arm.cc#newcode3783 src/arm/lithium-codegen-arm.cc:3783: Register temp = ToRegister(instr->TempAt(0)); Instead of allocating a temp here you could use scratch0() which is excluded from register allocation on ARM. If you do, please remove the temp from the lithium instruction. http://codereview.chromium.org/6368138/diff/1002/src/arm/lithium-codegen-arm.cc#newcode3803 src/arm/lithium-codegen-arm.cc:3803: Register temp2 = ToRegister(instr->TempAt(1)); Could use scratch0(). http://codereview.chromium.org/6368138/diff/1002/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/6368138/diff/1002/src/hydrogen-instructions.h#newcode2193 src/hydrogen-instructions.h:2193: protected: Blank line before protected? http://codereview.chromium.org/6368138/diff/1002/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6368138/diff/1002/src/ia32/lithium-codegen-ia32.cc#newcode3582 src/ia32/lithium-codegen-ia32.cc:3582: Label true_label; Make these NearLabel? http://codereview.chromium.org/6368138/diff/1002/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6368138/diff/1002/src/runtime.cc#newcode6717 src/runtime.cc:6717: Handle<Object> result = Execution::New( Move "Execution::New(" to the next line as well? http://codereview.chromium.org/6368138/diff/1002/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6368138/diff/1002/src/x64/lithium-codegen-x64.cc#newcode2254 src/x64/lithium-codegen-x64.cc:2254: Label true_label; NearLabel? http://codereview.chromium.org/6368138/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
