LGTM
http://codereview.chromium.org/6312193/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6312193/diff/1/src/x64/lithium-codegen-x64.cc#newcode1896 src/x64/lithium-codegen-x64.cc:1896: times_pointer_size, I think we should change this to times_pointer_size on ia32 as well http://codereview.chromium.org/6312193/diff/1/src/x64/lithium-codegen-x64.cc#newcode1905 src/x64/lithium-codegen-x64.cc:1905: times_pointer_size, Same here - we should change this to times_pointer_size on ia32 as well to be consistent (actually, we should also change it in DoLoadKeyedFastElement on IA32) http://codereview.chromium.org/6312193/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
