LGTM
http://codereview.chromium.org/6481001/diff/1/src/parser.cc File src/parser.cc (right): http://codereview.chromium.org/6481001/diff/1/src/parser.cc#newcode3934 src/parser.cc:3934: Nice and simple way of avoiding setters! http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-1130.js File test/mjsunit/regress/regress-1130.js (right): http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-1130.js#newcode35 test/mjsunit/regress/regress-1130.js:35: eval("(function() { const x; var x })")(); To ensure that an exception is thrown, add an assertUnreachable() here, after the eval. http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-1130.js#newcode37 test/mjsunit/regress/regress-1130.js:37: exception = e; Then move the typecheck inside the catch, and drop the "exception" variable. http://codereview.chromium.org/6481001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
