Thanks a lot for review, Lasse
http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-1130.js File test/mjsunit/regress/regress-1130.js (right): http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-1130.js#newcode35 test/mjsunit/regress/regress-1130.js:35: eval("(function() { const x; var x })")(); On 2011/02/10 14:26:18, Lasse Reichstein wrote:
To ensure that an exception is thrown, add an assertUnreachable()
here, after
the eval.
Done. http://codereview.chromium.org/6481001/diff/1/test/mjsunit/regress/regress-1130.js#newcode37 test/mjsunit/regress/regress-1130.js:37: exception = e; On 2011/02/10 14:26:18, Lasse Reichstein wrote:
Then move the typecheck inside the catch, and drop the "exception"
variable. Done. http://codereview.chromium.org/6481001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
