I think the approach will work.
We also need to do the same for MacroAssembler::InvokeFunction, and any
other
place that calls through a register.
We might want a comment in RelocWriter::Write (or wherever we emit the code
comments) to say that we rely on using the long encoding for comments (so
we can
patch it with anything).
It would be nice if we could somehow assert for each safepoint that the
reloc
info had changed by "delta" between before the call and after the call.
http://codereview.chromium.org/6499015/diff/2002/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):
http://codereview.chromium.org/6499015/diff/2002/src/ia32/assembler-ia32.h#newcode960
src/ia32/assembler-ia32.h:960: // Use --code-comments to enable.
We should probably update this comment to mention that force overrides
--nocode-comments.
http://codereview.chromium.org/6499015/diff/2002/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
http://codereview.chromium.org/6499015/diff/2002/src/ia32/lithium-codegen-ia32.cc#newcode58
src/ia32/lithium-codegen-ia32.cc:58:
codegen_->masm()->RecordComment(NULL, true);
I guess printing comments works with NULL strings?
We might want to put some distinct static constant string so we can
recognize these when dumping code and reloc info. (I suggest "Kick
me!").
http://codereview.chromium.org/6499015/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
