It would be nice if we could somehow assert for each safepoint that the
reloc
info had changed by "delta" between before the call and after the call.
We are not sure how much space is actually needed for a call, this depends
on
usage of pc-jump instructions, so a call can be 1, 3, 4, 5 or 6 bytes long.
We
are, however, guaranteed that for normal calls that have reloc info we do
actually have room for this since the original call will also be preceded
by a
pc jump (since the pc delta between old and new calls will be the same)
http://codereview.chromium.org/6499015/diff/2002/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):
http://codereview.chromium.org/6499015/diff/2002/src/ia32/assembler-ia32.h#newcode960
src/ia32/assembler-ia32.h:960: // Use --code-comments to enable.
On 2011/02/15 12:19:15, Kevin Millikin wrote:
We should probably update this comment to mention that force overrides
--nocode-comments.
Done.
http://codereview.chromium.org/6499015/diff/2002/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
http://codereview.chromium.org/6499015/diff/2002/src/ia32/lithium-codegen-ia32.cc#newcode58
src/ia32/lithium-codegen-ia32.cc:58:
codegen_->masm()->RecordComment(NULL, true);
On 2011/02/15 12:19:15, Kevin Millikin wrote:
I guess printing comments works with NULL strings?
We might want to put some distinct static constant string so we can
recognize
these when dumping code and reloc info. (I suggest "Kick me!").
Printing with null works, but I changed this to a static string in the
assembler class
http://codereview.chromium.org/6499015/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
