A couple of questions. This is looking good. We need to port it to ARM and
to
x64 and then it looks just about ready to go. :-)
http://codereview.chromium.org/6534022/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
http://codereview.chromium.org/6534022/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode148
src/ia32/lithium-codegen-ia32.cc:148: __ CallStub(&stub);
Is there a reason for not using CallCode here which would deal with the
safepoint?
http://codereview.chromium.org/6534022/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode150
src/ia32/lithium-codegen-ia32.cc:150: __
CallRuntime(Runtime::kNewContext, 1);
Ditto, is there a reason for not using CallRuntime here which would deal
with the safepoint?
http://codereview.chromium.org/6534022/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode152
src/ia32/lithium-codegen-ia32.cc:152:
safepoints_.DefineSafepoint(masm(), Safepoint::kSimple, 0,
If you cannot use the function above, could you use the RecordSafepoint
function here?
http://codereview.chromium.org/6534022/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode171
src/ia32/lithium-codegen-ia32.cc:171: // registers, so we have use a
third register to avoid
we have use -> we have to use
http://codereview.chromium.org/6534022/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
