Could you upload again Andreas? I don't see the changes for the other
backends.

Oops, sorry, forgot to add the files. Done.

I still find the safepoint definition too raw, but feel free to play with that
after committing the change.

Done now (in all backends).



http://codereview.chromium.org/6534022/diff/6001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6534022/diff/6001/src/ia32/lithium-codegen-ia32.cc#newcode178
src/ia32/lithium-codegen-ia32.cc:178:
safepoints_.DefineSafepoint(masm(), Safepoint::kSimple, 0,
On 2011/02/22 08:23:42, Mads Ager wrote:
I still find this too raw. We should hide this away. We can allocate a
pointer
map with no pointers and use the normal way.

Done: factored out into a new variation of the RecordSafepoint method.

http://codereview.chromium.org/6534022/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to