LGTM

http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status
File test/sputnik/sputnik.status (right):

http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status#newcode193
test/sputnik/sputnik.status:193: # with undefined/null. Test expects
otherwise.
Object.prototype.toString has special cases for null and undefined as
the two first steps of the algorithm. After that, it does ToObject on
the remaining values.

http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status#newcode199
test/sputnik/sputnik.status:199: # V8 should not wrap this when calling
builtin functions
We should have avoided that already. Are we wrapping this now?

http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status#newcode223
test/sputnik/sputnik.status:223: S15.3_A3_T1: FAIL
Agree.

http://codereview.chromium.org/6542066/diff/1/test/sputnik/sputnik.status#newcode225
test/sputnik/sputnik.status:225: S15.3_A3_T3: FAIL
And agree.
The tests did depend on a variable not being present before the
assignment to the global property.

http://codereview.chromium.org/6542066/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to