LGTM.
http://codereview.chromium.org/6599002/diff/2002/src/ia32/codegen-ia32.cc File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/6599002/diff/2002/src/ia32/codegen-ia32.cc#newcode5369 src/ia32/codegen-ia32.cc:5369: if (node->handle()->IsSmi()) { I think MacroAssembler::Set will do the right thing for all handles, so you don't need to check for or handle (ha ha) smis specially. http://codereview.chromium.org/6599002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
