LGTM
http://codereview.chromium.org/6594074/diff/1/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): http://codereview.chromium.org/6594074/diff/1/src/x64/full-codegen-x64.cc#newcode2971 src/x64/full-codegen-x64.cc:2971: VisitForStackValue(args->at(2)); Could we put the values directly into registers, and only push them if we need to go to runtime? Or will we always need to push them anyway, to free up registers? http://codereview.chromium.org/6594074/diff/1/src/x64/full-codegen-x64.cc#newcode2997 src/x64/full-codegen-x64.cc:2997: __ movq(index_2, Operand(rsp, 0)); Mutiply by kPointerSize here too, just for consistency. http://codereview.chromium.org/6594074/diff/1/src/x64/full-codegen-x64.cc#newcode3001 src/x64/full-codegen-x64.cc:3001: __ movq(temp, FieldOperand(object, JSArray::kLengthOffset)); Make a comment that since the array is in fast elements mode, the length must be a smi. (Do we enforce that in ToUInt32, or could we cheat it to be a HeapNumber holding a potential smi value by doing something like: arr.length = 87.5 / 2.5; ?) http://codereview.chromium.org/6594074/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
