Can you explain why this changes the memory behavior of the code? I can't
see it
:)
I see no advantage in making this an external class (but that might be
related
to not seeing any difference).
I also think that Kevin is right, and we should make it a
ZoneList<JumpTableEntry>.
http://codereview.chromium.org/6647012/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
http://codereview.chromium.org/6647012/diff/1/src/x64/lithium-codegen-x64.cc#newcode549
src/x64/lithium-codegen-x64.cc:549: jump_info->SetAddress(entry);
Why?
Is there any advantage in this, relative to setting the address in the
constructor? (Because it does mean setting the same memory's value twice
and temporarily leaving the entry in an invalid state).
(On the other hand, if you do make it a list of JumpTableEntrys instead
of pointers to same, you might want a no-argument constructor and a
setter that initializes the object).
http://codereview.chromium.org/6647012/diff/1/src/x64/lithium-codegen-x64.h
File src/x64/lithium-codegen-x64.h (right):
http://codereview.chromium.org/6647012/diff/1/src/x64/lithium-codegen-x64.h#newcode277
src/x64/lithium-codegen-x64.h:277: class JumpTableEntry : public
ZoneObject {
Why create an external class for a purely internal data-structure?
Especially when you need to make it a friend class anyway?
http://codereview.chromium.org/6647012/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
