LGTM
http://codereview.chromium.org/6694044/diff/10001/src/bootstrapper.cc File src/bootstrapper.cc (right): http://codereview.chromium.org/6694044/diff/10001/src/bootstrapper.cc#newcode296 src/bootstrapper.cc:296: // Function instance maps. Funcion literal maps are created initially with Funcion -> Function http://codereview.chromium.org/6694044/diff/10001/src/bootstrapper.cc#newcode589 src/bootstrapper.cc:589: Delete this line? http://codereview.chromium.org/6694044/diff/10001/src/factory.cc File src/factory.cc (right): http://codereview.chromium.org/6694044/diff/10001/src/factory.cc#newcode834 src/factory.cc:834: Handle<JSFunction> Factory::NewFunctionWithoutPrototypeStrictHelper( Instead of duplicating the code here, would it make sense to parameterize NewFunctionWithoutPrototype with a strict mode flag and then select the right map in NewFunctionWithoutPrototypeHelper? Or maybe have only one helper that takes a strict mode flags and uses that to select the map? http://codereview.chromium.org/6694044/diff/10001/src/factory.cc#newcode845 src/factory.cc:845: Handle<JSFunction> Factory::NewFunctionWithoutPrototypeStrict( NewStrictFunctionWithoutPrototype? http://codereview.chromium.org/6694044/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
