Done with the final touches. Will now try to land.
http://codereview.chromium.org/6694044/diff/10001/src/bootstrapper.cc File src/bootstrapper.cc (right): http://codereview.chromium.org/6694044/diff/10001/src/bootstrapper.cc#newcode296 src/bootstrapper.cc:296: // Function instance maps. Funcion literal maps are created initially with On 2011/03/17 07:48:25, Mads Ager wrote:
Funcion -> Function
Done. http://codereview.chromium.org/6694044/diff/10001/src/bootstrapper.cc#newcode589 src/bootstrapper.cc:589: On 2011/03/17 07:48:25, Mads Ager wrote:
Delete this line?
Done. http://codereview.chromium.org/6694044/diff/10001/src/factory.cc File src/factory.cc (right): http://codereview.chromium.org/6694044/diff/10001/src/factory.cc#newcode834 src/factory.cc:834: Handle<JSFunction> Factory::NewFunctionWithoutPrototypeStrictHelper( On 2011/03/17 07:48:25, Mads Ager wrote:
Instead of duplicating the code here, would it make sense to
parameterize
NewFunctionWithoutPrototype with a strict mode flag and then select
the right
map in NewFunctionWithoutPrototypeHelper? Or maybe have only one
helper that
takes a strict mode flags and uses that to select the map?
Done. http://codereview.chromium.org/6694044/diff/10001/src/factory.cc#newcode845 src/factory.cc:845: Handle<JSFunction> Factory::NewFunctionWithoutPrototypeStrict( On 2011/03/17 07:48:25, Mads Ager wrote:
NewStrictFunctionWithoutPrototype?
This function went away now that I removed the code duplication. http://codereview.chromium.org/6694044/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
