http://codereview.chromium.org/6713074/diff/1/src/assembler.h File src/assembler.h (right):
http://codereview.chromium.org/6713074/diff/1/src/assembler.h#newcode504 src/assembler.h:504: explicit ExternalReference(Builtins::CFunctionId id, Isolate* isolate); I think these should be moved to some class that already has the current isolate pointer, say, to the Assembler. Otherwise, the code looks too nasty. http://codereview.chromium.org/6713074/diff/1/src/ia32/builtins-ia32.cc File src/ia32/builtins-ia32.cc (right): http://codereview.chromium.org/6713074/diff/1/src/ia32/builtins-ia32.cc#newcode103 src/ia32/builtins-ia32.cc:103: __ jmp(Handle<Code>(masm->isolate()->builtins()->builtin( There's still one more TLS read here for the handle. I think we should introduce a helper (maybe on Builtins) because this pattern is rather common. Feel free to do this in a follow up patch. http://codereview.chromium.org/6713074/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
