LGTM
http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h File include/v8-profiler.h (right): http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h#newcode143 include/v8-profiler.h:143: void Delete() const; "const" looks weird here. http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h#newcode392 include/v8-profiler.h:392: void Delete() const; Ditto. http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h#newcode496 include/v8-profiler.h:496: * are freed by calling the Delete class function. Accidental edit? http://codereview.chromium.org/6685084/diff/3001/src/api.cc File src/api.cc (right): http://codereview.chromium.org/6685084/diff/3001/src/api.cc#newcode5084 src/api.cc:5084: const_cast<i::CpuProfile*>( Dropping "const" will allow to avoid this const_cast. http://codereview.chromium.org/6685084/diff/3001/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/6685084/diff/3001/src/profile-generator.cc#newcode553 src/profile-generator.cc:553: if (*list_ptr) { nit: Use explicit != NULL comparison. http://codereview.chromium.org/6685084/diff/3001/src/profile-generator.cc#newcode673 src/profile-generator.cc:673: p; != NULL http://codereview.chromium.org/6685084/diff/3001/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): http://codereview.chromium.org/6685084/diff/3001/test/cctest/test-cpu-profiler.cc#newcode287 test/cctest/test-cpu-profiler.cc:287: CHECK_EQ(NULL, v8::CpuProfiler::FindProfile(uid1)); It'd be nice to test this again later to make sure it won't reappear. http://codereview.chromium.org/6685084/diff/3001/test/cctest/test-cpu-profiler.cc#newcode307 test/cctest/test-cpu-profiler.cc:307: CHECK_EQ(NULL, v8::CpuProfiler::FindProfile(uid2)); Same here. http://codereview.chromium.org/6685084/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
