http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h File include/v8-profiler.h (right):
http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h#newcode143 include/v8-profiler.h:143: void Delete() const; On 2011/03/22 14:30:36, Vitaly Repeshko wrote:
"const" looks weird here.
Hmm, maybe. I added 'const' because all methods return const pointers (to emphasize that embedder can't do much with them). So calling a non-const Delete will require embedder to do a const_cast. But probably it's OK, as it attracts more attention to calls to this method. http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h#newcode392 include/v8-profiler.h:392: void Delete() const; On 2011/03/22 14:30:36, Vitaly Repeshko wrote:
Ditto.
Done. http://codereview.chromium.org/6685084/diff/3001/include/v8-profiler.h#newcode496 include/v8-profiler.h:496: * are freed by calling the Delete class function. On 2011/03/22 14:30:36, Vitaly Repeshko wrote:
Accidental edit?
Ah, yes. Massive renaming. Reverted. http://codereview.chromium.org/6685084/diff/3001/src/api.cc File src/api.cc (right): http://codereview.chromium.org/6685084/diff/3001/src/api.cc#newcode5084 src/api.cc:5084: const_cast<i::CpuProfile*>( On 2011/03/22 14:30:36, Vitaly Repeshko wrote:
Dropping "const" will allow to avoid this const_cast.
Done. http://codereview.chromium.org/6685084/diff/3001/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/6685084/diff/3001/src/profile-generator.cc#newcode553 src/profile-generator.cc:553: if (*list_ptr) { On 2011/03/22 14:30:36, Vitaly Repeshko wrote:
nit: Use explicit != NULL comparison.
Done. http://codereview.chromium.org/6685084/diff/3001/src/profile-generator.cc#newcode673 src/profile-generator.cc:673: p; On 2011/03/22 14:30:36, Vitaly Repeshko wrote:
!= NULL
Done. http://codereview.chromium.org/6685084/diff/3001/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): http://codereview.chromium.org/6685084/diff/3001/test/cctest/test-cpu-profiler.cc#newcode287 test/cctest/test-cpu-profiler.cc:287: CHECK_EQ(NULL, v8::CpuProfiler::FindProfile(uid1)); On 2011/03/22 14:30:36, Vitaly Repeshko wrote:
It'd be nice to test this again later to make sure it won't reappear.
Added a couple of times more after. http://codereview.chromium.org/6685084/diff/3001/test/cctest/test-cpu-profiler.cc#newcode307 test/cctest/test-cpu-profiler.cc:307: CHECK_EQ(NULL, v8::CpuProfiler::FindProfile(uid2)); On 2011/03/22 14:30:36, Vitaly Repeshko wrote:
Same here.
Done. http://codereview.chromium.org/6685084/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
