LGTM I think we should add more testing though.
http://codereview.chromium.org/6759054/diff/1004/include/v8.h File include/v8.h (right): http://codereview.chromium.org/6759054/diff/1004/include/v8.h#newcode1656 include/v8.h:1656: * Returns a context in which the object was created. a context -> the context http://codereview.chromium.org/6759054/diff/1004/src/api.cc File src/api.cc (right): http://codereview.chromium.org/6759054/diff/1004/src/api.cc#newcode2882 src/api.cc:2882: static i::Context* creationContext(i::JSObject* object) { Use Google naming convention please: CreationContext http://codereview.chromium.org/6759054/diff/1004/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/6759054/diff/1004/test/cctest/test-api.cc#newcode13634 test/cctest/test-api.cc:13634: THREADED_TEST(CreationContext) { Would be nice to extend this test with stuff created through the API. In particular, there is an API function path in your code that you do not test. http://codereview.chromium.org/6759054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
