Thanks a lot for review, Mads. Submitting.
http://codereview.chromium.org/6759054/diff/1004/include/v8.h File include/v8.h (right): http://codereview.chromium.org/6759054/diff/1004/include/v8.h#newcode1656 include/v8.h:1656: * Returns a context in which the object was created. On 2011/04/01 11:19:38, Mads Ager wrote:
a context -> the context
Done. http://codereview.chromium.org/6759054/diff/1004/src/api.cc File src/api.cc (right): http://codereview.chromium.org/6759054/diff/1004/src/api.cc#newcode2882 src/api.cc:2882: static i::Context* creationContext(i::JSObject* object) { On 2011/04/01 11:19:38, Mads Ager wrote:
Use Google naming convention please: CreationContext
Done. http://codereview.chromium.org/6759054/diff/1004/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/6759054/diff/1004/test/cctest/test-api.cc#newcode13634 test/cctest/test-api.cc:13634: THREADED_TEST(CreationContext) { On 2011/04/01 11:19:38, Mads Ager wrote:
Would be nice to extend this test with stuff created through the API.
In
particular, there is an API function path in your code that you do not
test. Done. I'll add more if you think it's still not enough. http://codereview.chromium.org/6759054/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
