LGTM, but let's wait for Søren's comments as well.

http://codereview.chromium.org/6804015/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6804015/diff/1/src/runtime.cc#newcode9825
src/runtime.cc:9825: // The context_ is a with block from the outer
function.
maybe assert this: ASSRT(context_->has_extension())?

http://codereview.chromium.org/6804015/diff/1/test/mjsunit/debug-scopes.js
File test/mjsunit/debug-scopes.js (right):

http://codereview.chromium.org/6804015/diff/1/test/mjsunit/debug-scopes.js#newcode148
test/mjsunit/debug-scopes.js:148: if
(!scope.scopeObject().property('').isUndefined()) {
just curious, what are those properties with empty names?

http://codereview.chromium.org/6804015/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to