On Wed, Apr 6, 2011 at 9:41 PM, <[email protected]> wrote: > Added a couple more tests. > > On 2011/04/06 16:41:49, antonm wrote: >> >> LGTM, but let's wait for Søren's comments as well. > >> http://codereview.chromium.org/6804015/diff/1/src/runtime.cc >> File src/runtime.cc (right): > >> http://codereview.chromium.org/6804015/diff/1/src/runtime.cc#newcode9825 >> src/runtime.cc:9825: // The context_ is a with block from the outer >> function. >> maybe assert this: ASSRT(context_->has_extension())? > > Done. > >> http://codereview.chromium.org/6804015/diff/1/test/mjsunit/debug-scopes.js >> File test/mjsunit/debug-scopes.js (right): > > > http://codereview.chromium.org/6804015/diff/1/test/mjsunit/debug-scopes.js#newcode148 >> >> test/mjsunit/debug-scopes.js:148: if >> (!scope.scopeObject().property('').isUndefined()) { >> just curious, what are those properties with empty names? > > Have no idea, but in case > function closure_in_with_2() { > with({x:1}) { > (function inner(x) { > with({x:3}) { > debugger; > } > })(2); > } > } > properties of local scope of function 'inner' will contain a property with > empty > name and value the function itself. We may want to hide such properties from > debugger clients but then we should do the same with .catch-var
Thanks a lot. If it's synthesized var, maybe we should give it some better name, but that's definitely unrelated to this CL. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
