http://codereview.chromium.org/6812046/diff/1/src/v8globals.h
File src/v8globals.h (right):

http://codereview.chromium.org/6812046/diff/1/src/v8globals.h#newcode350
src/v8globals.h:350: explicit DoubleRepresentation(double x) {
memcpy(&bits, &x, sizeof(bits)); }
agree. Removed.

http://codereview.chromium.org/6812046/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/6812046/diff/1/src/x64/code-stubs-x64.cc#newcode1245
src/x64/code-stubs-x64.cc:1245: {  // See if there were smi values
stored in HeapNumbers.
LoadNumberAsIntegers will do truncating conversion as ToInteger32 (it's
used before bit-ops). It doesn't check whether the value is a valid smi
before truncating.
We don't want that here - if the value isn't something that could be a
smi, we should fail and go to the type transition.
There is no bailout in the code that allows us to do this.

http://codereview.chromium.org/6812046/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to