LGTM. See comments.
http://codereview.chromium.org/6812046/diff/6/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/6812046/diff/6/src/x64/code-stubs-x64.cc#newcode471 src/x64/code-stubs-x64.cc:471: // (If you just want to fall through in all cases, put the success Why let the user of this function make a mistake. NULL means that all successes fall through, non-NULL means that all successes go there. http://codereview.chromium.org/6812046/diff/6/src/x64/code-stubs-x64.cc#newcode2102 src/x64/code-stubs-x64.cc:2102: __ LoadRoot(heap_number_root, Heap::kHeapNumberMapRootIndex); Shouldn't this be called heap_number_map? http://codereview.chromium.org/6812046/diff/6/src/x64/code-stubs-x64.cc#newcode2124 src/x64/code-stubs-x64.cc:2124: // One of first or second should be non-smi if we get here. Second should be non-smi if we get here. http://codereview.chromium.org/6812046/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
