LGTM
http://codereview.chromium.org/6820003/diff/6/src/messages.cc File src/messages.cc (right): http://codereview.chromium.org/6820003/diff/6/src/messages.cc#newcode134 src/messages.cc:134: v8::TryCatch tryCatch; nit: noCamelCase http://codereview.chromium.org/6820003/diff/6/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/6820003/diff/6/test/cctest/test-api.cc#newcode8683 test/cctest/test-api.cc:8683: if (--call_depth) CompileRun("throw 'ThrowInJS';"); In case we re-entered this message callback, should we assert that it got its own exception? http://codereview.chromium.org/6820003/diff/6/test/cctest/test-api.cc#newcode8714 test/cctest/test-api.cc:8714: call_depth = 5; 5 is arbitrary here, right? In any case, it'd be nice to have a comment. http://codereview.chromium.org/6820003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
