http://codereview.chromium.org/6875003 should address 2 of 3 your
suggestions.
http://codereview.chromium.org/6820003/diff/6/src/messages.cc
File src/messages.cc (right):
http://codereview.chromium.org/6820003/diff/6/src/messages.cc#newcode134
src/messages.cc:134: v8::TryCatch tryCatch;
On 2011/04/11 19:37:39, Vitaly Repeshko wrote:
nit: noCamelCase
Done.
http://codereview.chromium.org/6820003/diff/6/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
http://codereview.chromium.org/6820003/diff/6/test/cctest/test-api.cc#newcode8683
test/cctest/test-api.cc:8683: if (--call_depth) CompileRun("throw
'ThrowInJS';");
On 2011/04/11 19:37:39, Vitaly Repeshko wrote:
In case we re-entered this message callback, should we assert that it
got its
own exception?
I don't think it's important for the given test.
http://codereview.chromium.org/6820003/diff/6/test/cctest/test-api.cc#newcode8714
test/cctest/test-api.cc:8714: call_depth = 5;
On 2011/04/11 19:37:39, Vitaly Repeshko wrote:
5 is arbitrary here, right? In any case, it'd be nice to have a
comment.
Done.
http://codereview.chromium.org/6820003/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
