Drive-by.
http://codereview.chromium.org/6879081/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6879081/diff/1/src/arm/code-stubs-arm.cc#newcode1983 src/arm/code-stubs-arm.cc:1983: if (!mode_ == UNARY_OVERWRITE) { !mode_ == should be mode_ != http://codereview.chromium.org/6879081/diff/1/src/arm/code-stubs-arm.cc#newcode1987 src/arm/code-stubs-arm.cc:1987: __ AllocateHeapNumber(r2, r3, r4, r6, slow); This will generate a type transition on a GC. That gives wrong type feedback to the Cranker because it goes generic. http://codereview.chromium.org/6879081/diff/1/src/arm/code-stubs-arm.cc#newcode2003 src/arm/code-stubs-arm.cc:2003: __ Call(stub.GetCode(), RelocInfo::CODE_TARGET); tail call http://codereview.chromium.org/6879081/diff/1/src/arm/code-stubs-arm.cc#newcode2004 src/arm/code-stubs-arm.cc:2004: __ pop(lr); Instead of push-call-pop you can use a tail call ie a jump. http://codereview.chromium.org/6879081/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
