thanks for the review. committing.
http://codereview.chromium.org/6880010/diff/3077/src/heap-inl.h File src/heap-inl.h (right): http://codereview.chromium.org/6880010/diff/3077/src/heap-inl.h#newcode478 src/heap-inl.h:478: On 2011/04/20 20:07:40, Erik Corry wrote:
2 blank lines
Done. http://codereview.chromium.org/6880010/diff/3077/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/6880010/diff/3077/src/heap.cc#newcode85 src/heap.cc:85: reserved_semispace_size_(8*MB), On 2011/04/20 20:07:40, Erik Corry wrote:
We have until now limited max semispace size to 4mb on the gc branch.
this
costs us performance but helps pause time. if we want to experiment
with this
lets do it as a separate change.
ooops. I thought I paid special attention to merge this correctly. http://codereview.chromium.org/6880010/diff/3077/src/mark-compact-inl.h File src/mark-compact-inl.h (right): http://codereview.chromium.org/6880010/diff/3077/src/mark-compact-inl.h#newcode56 src/mark-compact-inl.h:56: // TODO(gc) !!!!!! On 2011/04/20 20:07:40, Erik Corry wrote:
Marking has a heap_ field so this is easy to fix.
Done. http://codereview.chromium.org/6880010/diff/3077/src/serialize.cc File src/serialize.cc (right): http://codereview.chromium.org/6880010/diff/3077/src/serialize.cc#newcode516 src/serialize.cc:516: 41, On 2011/04/20 20:07:40, Erik Corry wrote:
oooops
Done. http://codereview.chromium.org/6880010/diff/3077/src/spaces-inl.h File src/spaces-inl.h (right): http://codereview.chromium.org/6880010/diff/3077/src/spaces-inl.h#newcode280 src/spaces-inl.h:280: return object->map() == HEAP->raw_unchecked_free_space_map() On 2011/04/20 20:07:40, Erik Corry wrote:
I think this needs a todo
Done. http://codereview.chromium.org/6880010/diff/3077/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/6880010/diff/3077/src/spaces.cc#newcode1375 src/spaces.cc:1375: set_map(HEAP->raw_unchecked_free_space_map()); On 2011/04/20 20:07:40, Erik Corry wrote:
Needs a todo
Done. http://codereview.chromium.org/6880010/diff/3077/src/store-buffer.cc File src/store-buffer.cc (right): http://codereview.chromium.org/6880010/diff/3077/src/store-buffer.cc#newcode318 src/store-buffer.cc:318: Address* top = reinterpret_cast<Address*>(HEAP->store_buffer_top()); On 2011/04/20 20:07:40, Erik Corry wrote:
Use heap_ here and below
here and below done where possible. GCPrologue/GCEpilogue are static functions. TODO added. http://codereview.chromium.org/6880010/diff/3077/src/store-buffer.h File src/store-buffer.h (right): http://codereview.chromium.org/6880010/diff/3077/src/store-buffer.h#newcode43 src/store-buffer.h:43: // TODO(gc) ISOLATESMERGE convert to non static class On 2011/04/20 20:07:40, Erik Corry wrote:
Is this not done?
indeed. http://codereview.chromium.org/6880010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
